Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ci: fix CI skip script hole into release/1.4.x #4327

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #4323 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


In some environments, the script will not fail despite SKIP_CHECK_BRANCH being unset, leading to the script explicitly skipping CI when it should fail fast.

Prevent this by explicitly checking for the env var.

Also fix a small bug where we're incorrectly requiring ',' in the .changelog directory name, which means we'll never skip changelog entries.

This change is a port of hashicorp/consul#21741.

Testing

❯ ./.github/scripts/check_skip_ci.sh
./.github/scripts/check_skip_ci.sh: line 27: SKIP_CHECK_BRANCH: SKIP_CHECK_BRANCH is required

❯ export SKIP_CHECK_BRANCH=net-10843-cannot-add-tolerations-to-apigateway
❯ ./.github/scripts/check_skip_ci.sh
checking file: .changelog/4313.txt
checking file: .github/scripts/check_skip_ci.sh
checking file: .go-version
non-skippable file changed: .go-version
Changes detected in non-documentation files - will not skip tests and build

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core merged commit 32c7ee5 into release/1.4.x Sep 17, 2024
29 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/fix-scan-ci-skip-config/visually-musical-yeti branch September 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants